Switching to use FileOpener instead of FileLoader #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…FileOpener as well [ghstack-poisoned]
facebook-github-bot
added
the
CLA Signed
|
Note that, since pytorch/pytorch#70367 has not landed, the CI tests here are expected to fail. |
ejguan
approved these changes
Dec 30, 2021
…g to IoPathFileOpener as well" This PR is dependent on pytorch/pytorch#70367, which renames `FileLoader` to `FileOpener` in PyTorch. Core library. Then, this PR switches all `TorchData` usage of `FileLoader` to `FileOpener`, as well as renaming `IoPathFileLoader` to `IoPathFileOpener` (the functional name changes as well). Downstream users of those DataPipes please be aware of that. Fixes #103. cc: ejguan @VitalyFedyunin pmeier @Nayef211 [ghstack-poisoned]
NivekT
changed the title
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This PR is dependent on pytorch/pytorch#70367, which renames `FileLoader` to `FileOpener` in PyTorch. Core library. Then, this PR switches all `TorchData` usage of `FileLoader` to `FileOpener`. Downstream users need to be aware of this. Fixes #103. cc: ejguan @VitalyFedyunin pmeier @Nayef211 Differential Revision: [D33368187](https://our.internmc.facebook.com/intern/diff/D33368187) [ghstack-poisoned]
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This PR is dependent on pytorch/pytorch#70367, which renames `FileLoader` to `FileOpener` in PyTorch. Core library. Then, this PR switches all `TorchData` usage of `FileLoader` to `FileOpener`. Downstream users need to be aware of this. Fixes #103. cc: ejguan @VitalyFedyunin pmeier @Nayef211 Differential Revision: [D33368187](https://our.internmc.facebook.com/intern/diff/D33368187) [ghstack-poisoned]
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This PR is dependent on pytorch/pytorch#70367, which renames `FileLoader` to `FileOpener` in PyTorch. Core library. Then, this PR switches all `TorchData` usage of `FileLoader` to `FileOpener`. Downstream users need to be aware of this. Fixes #103. cc: ejguan @VitalyFedyunin pmeier @Nayef211 Differential Revision: [D33368187](https://our.internmc.facebook.com/intern/diff/D33368187) [ghstack-poisoned]
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
This PR is dependent on pytorch/pytorch#70367, which renames `FileLoader` to `FileOpener` in PyTorch. Core library. Then, this PR switches all `TorchData` usage of `FileLoader` to `FileOpener`. Downstream users need to be aware of this. Fixes #103. cc: ejguan @VitalyFedyunin pmeier @Nayef211 Differential Revision: [D33368187](https://our.internmc.facebook.com/intern/diff/D33368187) [ghstack-poisoned]
|
@NivekT has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
NivekT
added a commit
to pytorch/text
that referenced
this pull request
Jan 5, 2022
TorchData is changing its API, renaming `FileLoader` to `FileOpener` This PR should be landed after pytorch/data#148 is merged (the CI for this PR is expected to fail until then as well) [ghstack-poisoned]
NivekT
added a commit
to pytorch/text
that referenced
this pull request
Jan 5, 2022
TorchData is changing its API, renaming `FileLoader` to `FileOpener` This PR should be landed after pytorch/data#148 is merged (the CI for this PR is expected to fail until then as well) [ghstack-poisoned]
ejguan
added a commit
that referenced
this pull request
Jan 5, 2022
Fixes #158 Reverts the change of notebook from #148 Differential Revision: [D33437356](https://our.internmc.facebook.com/intern/diff/D33437356) [ghstack-poisoned]
ejguan
added a commit
that referenced
this pull request
Jan 5, 2022
Fixes #158 Reverts the change of notebook from #148 Differential Revision: [D33437356](https://our.internmc.facebook.com/intern/diff/D33437356) [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
This PR is dependent on pytorch/pytorch#70367, which renames
FileLoadertoFileOpenerin PyTorch. Core library. Then, this PR switches allTorchDatausage ofFileLoadertoFileOpener. Downstream users need to be aware of this.Fixes #103.
cc: @ejguan @VitalyFedyunin @pmeier @Nayef211
Differential Revision: D33368187