Skip to content

Select targets gpu fix #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Select targets gpu fix #317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
093ada4
Added test for target with gpu based model
Mar 8, 2020
a9cdb7f
Fixed tests.
Mar 8, 2020
20b037c
Kais Fix:
Mar 8, 2020
3e99fc9
blackified code
Mar 8, 2020
3f3a1b0
trying manual sorting
Mar 8, 2020
120903f
Refactored tests as requested
Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion captum/attr/_utils/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,6 +450,7 @@ def _select_targets(output: Tensor, target: TargetType) -> Tensor:

num_examples = output.shape[0]
dims = len(output.shape)
device = output.device
if isinstance(target, (int, tuple)):
return _verify_select_column(output, target)
elif isinstance(target, torch.Tensor):
Expand All @@ -467,7 +468,9 @@ def _select_targets(output: Tensor, target: TargetType) -> Tensor:
assert len(target) == num_examples, "Target list length does not match output!"
if isinstance(target[0], int):
assert dims == 2, "Output must be 2D to select tensor of targets."
return torch.gather(output, 1, torch.tensor(target).reshape(len(output), 1))
return torch.gather(
output, 1, torch.tensor(target, device=device).reshape(len(output), 1)
)
elif isinstance(target[0], tuple):
return torch.stack(
[
Expand Down
Loading