Adding matplotlib to Conda dependencies #314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivekmig
changed the title
There was a problem hiding this comment.
@vivekmig has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
NarineK
pushed a commit
to NarineK/captum-1
that referenced
this pull request
Nov 19, 2020
Summary: Noticed that matplotlib was included in setup.py and required for pip, but not for conda. Adding matplotlib so both are consistent. Pull Request resolved: pytorch#314 Reviewed By: orionr, NarineK Differential Revision: D20295348 Pulled By: vivekmig fbshipit-source-id: f9a4118ff808af8a60f38fce5576fe4f7a99336f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that matplotlib was included in setup.py and required for pip, but not for conda. Adding matplotlib so both are consistent.