Support Cache Class for Even Newer Versions of Transformers Library #1343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#1341) Summary: Pull Request resolved: pytorch#1341 Fixes D62210529 (now reverted by D62262760). Transformers library is now an optional dependency. We do not depend on it, however, we have some logic for `transformers` models here. The library will only be imported if a model already has the library in the corresponding environment. This TARGETS configuration prevents transformers version conflicts which e.g. caused T200877742. Add support for new transformers Cache objects. This may need changes in the future as it seems that LLMs handle Caching differently. Some handle Caching themselves, however, some of them do not and some of them don't support Caches yet. Llama models seem to have a `_supports_cache_class` flag that indicates whether this new Cache object is supported. If it isn't marked as supported, we assume it takes legacy format (tuple past values). Multiple checks added to ensure compatibility. (minor) Also, changed the defaults for LLM generation to dismiss warnings (does not change generation behavior). Differential Revision: D62408520
|
This pull request was exported from Phabricator. Differential Revision: D62468332 |
|
This pull request was exported from Phabricator. Differential Revision: D62468332 |
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Sep 10, 2024
…ytorch#1343) Summary: Pull Request resolved: pytorch#1343 Supports multiple and newer versions of the transformers library. Adds the `packaging` dependency as well to more robustly check package versions. Differential Revision: D62468332
craymichael
force-pushed
the
export-D62468332
branch
from
a9024bd to
aa9cee0
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62468332 |
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Sep 10, 2024
…ytorch#1343) Summary: Pull Request resolved: pytorch#1343 Supports multiple and newer versions of the transformers library. Adds the `packaging` dependency as well to more robustly check package versions. Differential Revision: D62468332
craymichael
force-pushed
the
export-D62468332
branch
from
aa9cee0 to
80867c6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D62468332 |
craymichael
added a commit
to craymichael/captum
that referenced
this pull request
Sep 10, 2024
…ytorch#1343) Summary: Pull Request resolved: pytorch#1343 Supports multiple and newer versions of the transformers library. Adds the `packaging` dependency as well to more robustly check package versions. Differential Revision: D62468332
craymichael
force-pushed
the
export-D62468332
branch
from
80867c6 to
636bd1c
Compare
…ytorch#1343) Summary: Pull Request resolved: pytorch#1343 Supports multiple and newer versions of the transformers library. Adds the `packaging` dependency as well to more robustly check package versions. Differential Revision: D62468332
|
This pull request was exported from Phabricator. Differential Revision: D62468332 |
craymichael
force-pushed
the
export-D62468332
branch
from
636bd1c to
8f22fa1
Compare
|
This pull request has been merged in 5839d52. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Supports multiple and newer versions of the transformers library. Adds the
packagingdependency as well to more robustly check package versions.Differential Revision: D62468332