-
Notifications
You must be signed in to change notification settings - Fork 228
add cuda install logs #832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@peterjc123 @seemethere |
windows/internal/cuda_install.bat
Outdated
) | ||
|
||
start /wait setup.exe -s %ARGS% | ||
sc query wususerv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo? also check line 190
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think both sc query wususerv
could be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's only used for debugging purposes
|
||
start /wait setup.exe -s %ARGS% | ||
sc query wususerv | ||
sc config wuauserv start= disabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @seemethere @malfet I'm not sure whether it will break something at the CircleCI side or not. Would you please open a ticket about it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows update would start again after net stop wususerv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But you set it to disabled instead of stopping it here, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. So far, CI only pass as the update service is disabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like ideally they wouldn’t be re-using runners between runs so this shouldn’t be a big issue.
Fix pytorch/pytorch#63139