Skip to content

Conversation

pearu
Copy link
Collaborator

@pearu pearu commented Aug 29, 2025

As in the title.

Previously, cmuarctic tests fail when using Python 3.13:

$ pytest -sv test/torchaudio_unittest/datasets/cmuarctic_test.py
<snip>
        with open(self._text, "r") as text:
>           walker = csv.reader(text, delimiter="\n")
                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
E           ValueError: bad delimiter value
E           
E           To execute this test, run the following from the base repo dir:
E               python test/torchaudio_unittest/datasets/cmuarctic_test.py TestCMUARCTIC.test_cmuarctic_str
E           
E           This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0

src/torchaudio/datasets/cmuarctic.py:131: ValueError

Note: the same issue is fixed in #3923 by avoiding csv.reader.

PLEASE NOTE THAT THE TORCHAUDIO REPOSITORY IS NO LONGER ACTIVELY MONITORED. You may not get a response. For open discussions, visit https://discuss.pytorch.org/.

@pearu pearu requested a review from a team as a code owner August 29, 2025 17:04
Copy link

pytorch-bot bot commented Aug 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/audio/4071

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 9 New Failures, 1 Unrelated Failure

As of commit fcedb8e with merge base 1c66402 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed label Aug 29, 2025
@pearu pearu force-pushed the pearu/fix-cmuarctic-py313 branch from a407a42 to fcedb8e Compare August 29, 2025 17:05
Copy link
Member

@NicolasHug NicolasHug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pearu , before merging can you make sure this still works as expected on 3.10?

@pearu
Copy link
Collaborator Author

pearu commented Sep 1, 2025

Thanks @pearu , before merging can you make sure this still works as expected on 3.10?

Confirming that the cmuarctic test passes on Python 3.10 as well.

@pearu pearu merged commit 7d4c0bf into pytorch:main Sep 1, 2025
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants