Skip to content

add typing_extensions as test dependencies which is required by modelopt #3743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release/2.8
Choose a base branch
from
Open

add typing_extensions as test dependencies which is required by modelopt #3743

wants to merge 1 commit into from
+1 −0

Conversation

lanluo-nvidia
Copy link
Collaborator

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@lanluo-nvidia lanluo-nvidia added the ciflow/binaries/all Build for all Python Versions label Aug 4, 2025
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 4, 2025

No ciflow labels are configured for this repo.
For information on how to enable CIFlow bot see this wiki

@meta-cla meta-cla bot added the cla signed label Aug 4, 2025
@github-actions github-actions bot added documentation Improvements or additions to documentation component: tests Issues re: Tests component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: build system Issues re: Build system component: api [Python] Issues re: Python API component: runtime component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: torch_compile labels Aug 4, 2025
@github-actions github-actions bot requested a review from apbose August 4, 2025 23:27
@lanluo-nvidia lanluo-nvidia changed the base branch from main to release/2.8 August 4, 2025 23:27
@lanluo-nvidia lanluo-nvidia marked this pull request as ready for review August 4, 2025 23:28
narendasan
narendasan approved these changes Aug 5, 2025
View reviewed changes
Copy link
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

narendasan
narendasan reviewed Aug 5, 2025
View reviewed changes
tests/py/requirements.txt
@@ -8,6 +8,7 @@ pytest>=8.2.1
pytest-xdist>=3.6.1
pyyaml
transformers==4.49.0
typing_extensions
nvidia-modelopt[all]; python_version >'3.9' and python_version <'3.13'
--extra-index-url https://pypi.nvidia.com
# flashinfer-python is not supported for python version 3.13 or higher
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point can we move to these being recorded as a group in pyproject.toml instead of in here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post 2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narendasan narendasan narendasan approved these changes

@apbose apbose Awaiting requested review from apbose

Assignees
No one assigned
Labels
ciflow/binaries/all Build for all Python Versions cla signed component: api [Python] Issues re: Python API component: build system Issues re: Build system component: conversion Issues re: Conversion stage component: converters Issues re: Specific op converters component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: runtime component: tests Issues re: Tests component: torch_compile documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lanluo-nvidia @narendasan