-
Notifications
You must be signed in to change notification settings - Fork 369
fix: prelu perf gap on Unet #3717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
95c2633
to
90fcd2b
Compare
9e171ba
to
cf0f12d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
If possible consider adding a test, we talked a bit about a new INetwork verification test based on expected numbers of ops. Might be a simple case to build the harness for |
@narendasan I'll merge this PR now and cherrypick to the release 2.8, and then work on the number of ops check in another PR for the next release. sounds like a plan? |
there's an error. will merge after fixing |
this case fails because
self.input_names: ['x'] Since |
Description
In Monai/Unet, I observed that Torch-TRT's prelu is slower than ONNX-TRT, and what is worse is that using prelu converter is even slower than decomposing it.
Update: The perf issue is because
to_copy
forces to insert Cast Layer which reduces latency.Fixes #3715 #3723
Type of change
Checklist: