Skip to content

Enhance unified_parse function #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

FindHao
Copy link
Member

@FindHao FindHao commented Jun 18, 2025

Enhance unified_parse function to accept output directory and additional parameters

Summary:

  • Updated the unified_parse function to include an output_dir parameter for specifying where to save parsed results.
  • Modified the test script to utilize the new output directory feature for improved log management.
  • Improved flexibility by allowing additional arguments to be passed to the parsing function.

FindHao added 2 commits June 17, 2025 20:19
…nal parameters

Summary:
- Updated the unified_parse function to include an output_dir parameter for specifying where to save parsed results.
- Modified the test script to utilize the new output directory feature for improved log management.
- Improved flexibility by allowing additional arguments to be passed to the parsing function.
Summary:
- Updated the unified_parse function to handle additional parameters such as rank and all_ranks for improved flexibility in parsing triton logs.
- Cleaned up whitespace in the function for better readability.
@FindHao FindHao marked this pull request as ready for review June 18, 2025 03:32
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jun 18, 2025
@facebook-github-bot
Copy link
Contributor

@FindHao has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Meta Open Source bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants