Skip to content

subprocess.(check_)call: add text argument new in 3.7 #8070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 14, 2022
Merged

Conversation

AlexWaygood
Copy link
Member

Fixes #7777

@github-actions

This comment has been minimized.

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I guess this was missed because passing text to check_call is a little unusual given there's check_output.

Lgtm, except that it's missing the version gate to 3.7

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also consider adding the new 3.11 Popen args everywhere

@AlexWaygood
Copy link
Member Author

Lgtm, except that it's missing the version gate to 3.7

Yeah, I agreed with @srittau here that typeshed support for 3.6 was soon to be going, so there was little point in complicating the stub: #7777 (comment).

But I don't feel too strongly about it, I'm fine with adding the version gate :)

@AlexWaygood
Copy link
Member Author

AlexWaygood commented Jun 14, 2022

Could also consider adding the new 3.11 Popen args everywhere

There's still some from 3.9 that haven't yet percolated through the stub: #7524. But I'd prefer to leave those (and the new 3.11 arguments) to future PRs.

@hauntsaninja
Copy link
Collaborator

Oh missed that comment. I'm fine with whatever!

@AlexWaygood
Copy link
Member Author

Oh missed that comment. I'm fine with whatever!

Well I've added the version guard now, so let's go with an accurate stub I guess 😆

@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood merged commit 60c2733 into master Jun 14, 2022
@AlexWaygood AlexWaygood deleted the subprocess branch June 14, 2022 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

subprocess.call() is missing text argument (in Python >=3.7)
2 participants