Skip to content

Improve _tkinter #6908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jan 13, 2022
Merged

Improve _tkinter #6908

merged 17 commits into from
Jan 13, 2022

Conversation

Akuli
Copy link
Collaborator

@Akuli Akuli commented Jan 13, 2022

Not really important, because _tkinter is mostly an implementation detail anyway, but I wanted to try stubgen with a C extension module.

@github-actions

This comment has been minimized.

4 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Akuli Akuli marked this pull request as draft January 13, 2022 14:18
Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed it, I trust the arguments are correct. Seems like a nice improvement.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@Akuli Akuli marked this pull request as ready for review January 13, 2022 14:35
@github-actions

This comment has been minimized.

1 similar comment
@github-actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@Akuli Akuli merged commit b77f994 into python:master Jan 13, 2022
@Akuli Akuli deleted the tkinter branch January 13, 2022 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants