Skip to content

Allow empty strings for show in tkinter.ttk.Treeview #6135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 9, 2021
Merged

Allow empty strings for show in tkinter.ttk.Treeview #6135

merged 1 commit into from
Oct 9, 2021

Conversation

A5rocks
Copy link
Contributor

@A5rocks A5rocks commented Oct 9, 2021 •
edited
Loading

Fixes #6134

Both __init__ and configure accept show='' without erroring, unlike show='abc', so I assume passing an empty string works for both.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2021

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

Akuli
Akuli approved these changes Oct 9, 2021
View reviewed changes
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Akuli Akuli merged commit ca983cd into python:master Oct 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akuli Akuli Akuli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tkinter Treeview show accepts empty string
2 participants
@A5rocks @Akuli