Skip to content

add lupa stubs #12650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Sep 16, 2024
Merged

add lupa stubs #12650

merged 11 commits into from
Sep 16, 2024

Conversation

RedContritio
Copy link
Contributor

  • add stubs for lupa

@RedContritio RedContritio force-pushed the lupa branch 2 times, most recently from 13220c4 to 4be7887 Compare September 12, 2024 19:32

This comment has been minimized.

@RedContritio RedContritio force-pushed the lupa branch 2 times, most recently from bde7cff to a852bf6 Compare September 12, 2024 19:43

This comment has been minimized.

2 similar comments

This comment has been minimized.

This comment has been minimized.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A few remarks below. Also, whenever using Any, it should be documented why Any is necessary and what the possible types are.

This comment has been minimized.

@RedContritio
Copy link
Contributor Author

RedContritio commented Sep 15, 2024

Thanks! A few remarks below. Also, whenever using Any, it should be documented why Any is necessary and what the possible types are.

I have removed almost all Anys, except for Callable[..., Any] used in decorators to represent arbitrary functions and *args: Any, **kwargs: Any used in variable arguments.

ps: The contents of luaXX.pyi and luajitXX.pyi are completely identical, so only one of them needs to be reviewed.

Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 2e9a61f into python:main Sep 16, 2024
48 checks passed
@RedContritio RedContritio deleted the lupa branch September 16, 2024 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants