Skip to content

Move socket into 2and3 #1149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 8, 2017
Merged

Move socket into 2and3 #1149

merged 2 commits into from
Apr 8, 2017

Conversation

euresti
Copy link
Contributor

@euresti euresti commented Apr 7, 2017

These files were already pretty similar so I just merged them together.

@JelleZijlstra
Copy link
Member

Looks good from reviewing the diff between the existing stubs, although the implementation in CPython has changed significantly.

Did notice a few things we can fix later:

  • Missing socket.fromshare and socket.socket.share (new in 3.3)
  • Python 2.7 appears to have socket.ssl() but it's not documented

@JelleZijlstra JelleZijlstra merged commit f741429 into python:master Apr 8, 2017
@euresti euresti deleted the socket branch April 8, 2017 11:54
hswong3i pushed a commit to alvistack/python-typeshed that referenced this pull request May 25, 2025
@srittau
Convert README.rst to README.md (python#1150)
5c45439 
Closes: python#1149
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@euresti @JelleZijlstra