-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
PEP 667: Clarify specification ambiguities and the expected impact #3845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 2 commits
Commits
Show all changes
54 commits
Select commit
Hold shift + click to select a range
ab71e9a
Add impact on exec() for PEP 667
gaogaotiantian 3d86025
Fix lint
gaogaotiantian 8729874
Apply suggestions from code review
gaogaotiantian e2f0b94
Apply @carljm suggestions from review
willingc 98edffa
Incorporate feedback and PyEval_GetLocals PR
ncoghlan 9a2a7d3
Syntax fixes, PEP 558 comparison tweaks
ncoghlan e67a37d
Move f_locals spec note to spec section
ncoghlan a2b6b33
Add missing space
ncoghlan 6be7b28
Indent ctypes example
ncoghlan f2423f0
Minor syntax and wording edits
ncoghlan 82f94fb
Reword mention of "real" locals.
ncoghlan 4a85e39
PEP link fix, minor text edits
ncoghlan 6115fbd
Add note about the extra PEP 558 C APIs being omitted
ncoghlan 669a0bc
Another link syntax fix
ncoghlan c68d02c
Merge branch 'main' into pep-667-exec-impact
ncoghlan 9a966dd
Fix incorrect prefix in function name
ncoghlan 98eddaf
Improve locals() implementation note
ncoghlan a8a700d
Clarify the note about deoptimization
ncoghlan 7808759
Be clear there is no `is_function` frame method
ncoghlan 6a89a65
More syntax and wording tweaks
ncoghlan 22494e4
Further updates
ncoghlan 828daa2
No joy on mixed syntax highlighting
ncoghlan 1bc2eaa
Remove leftover comma
ncoghlan a924f4b
Reword note about better optimization support
ncoghlan c5d35e1
Merge branch 'main' into pep-667-exec-impact
ncoghlan 32fc5fb
Address review comments from Barry & Tian
ncoghlan 6449585
Syntax fix
ncoghlan a0881b1
Fix typo
ncoghlan 8dec696
f_locals is mutable, not read-only!
ncoghlan 4151acb
Misc proofreading edits
ncoghlan 4871a39
Define exec/eval, fix proxy mutability
ncoghlan ad391ea
Fix syntax, update implementation note
ncoghlan 2269f65
Another syntax fix
ncoghlan 1539941
Make snapshot code consistent
ncoghlan 0c5aea9
Use 3.13 signature for eval spec
ncoghlan a846667
Merge branch 'main' into pep-667-exec-impact
ncoghlan 8abca04
Delay `PyEval_GetLocals` hard deprecation to 3.14
ncoghlan d3bff7b
Apply suggestions from code review
ncoghlan 40e59cb
Merge branch 'main' into pep-667-exec-impact
ncoghlan 1d4447d
Move locals rationale details to PEP 558
ncoghlan 80e115b
Merge remote-tracking branch 'origin/main' into pep-667-exec-impact
ncoghlan c84fc0d
Merge remote-tracking branch 'origin/main' into pep-667-exec-impact
ncoghlan b7b427f
Merge branch 'main' into pep-667-exec-impact
ncoghlan 544de0f
Merge branch 'main' into pep-667-exec-impact
ncoghlan ac5c974
Apply simple suggestions from code review
ncoghlan e21a718
Merge remote-tracking branch 'origin/main' into pep-667-exec-impact
ncoghlan 709c345
Address initial set of recent review comments
ncoghlan db15bf0
Extra keys can be removed
ncoghlan ea92f36
Split 'Summary of Changes' out from 'Specification'
ncoghlan 9d812fd
Avoid duplicate heading name
ncoghlan 56727f0
Extra key removal is implementation dependent
ncoghlan a27332d
Add refs for del/pop regression
ncoghlan 713ec6f
Fix typo
ncoghlan f875410
Merge branch 'main' into pep-667-exec-impact
ncoghlan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.