-
-
Notifications
You must be signed in to change notification settings - Fork 64
Add Greek translation #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
If we keep the common name, would it be worth to mention allowing exceptions in the repository name in PEP 545? https://peps.python.org/pep-0545/#create-github-repository
Maybe: ?
|
Re: https://peps.python.org/pep-0545/#add-translation-to-the-language-switcher
https://python-docs-gr.readthedocs.io/el/latest/bugs.html Looks good.
https://python-docs-gr.readthedocs.io/el/latest/tutorial/index.html A spot check found a little bit of English in https://python-docs-gr.readthedocs.io/el/latest/tutorial/errors.html#handling-exceptions
Looks good, except for
|
Hmm, that's odd. It looks like this is implemented in the po file.
Again, same thing. It looks like this is implemented in the po file, but does not appear in the built docs. Does anyone have an idea on why that might be? |
@lysnikolaou most probably there's a slight change in the original sources, on 3.13 branch, it would be best to update the files with the latest sources version. |
You can see this behavior also in Spanish version https://docs.python.org/es/3.13/library/functions.html#abs |
Brazilian Portuguese looks OK, so it is probably just out-of-date source string. |
Checking with the HEAD of 3.13, there seems to be some new content and some differences. Maybe the code snippets blocks affected the numbers 🤔
For comparison locally looks like 100% indeed:
|
Unhelpfully, there's divergence between ISO 3166-1 alpha-2 and ISO 639-1. Nevertheless, I think we should stick to ISO 639, the standard for classification of languages, for the avoidance of doubt. I hope this doesn't cause too much trouble. A |
We have completed the necessary updates to successfully publish version
|
Do you have updated numbers for the PEP 545 targets for 3.13 (which is |
For 3.12
For 3.13
|
There's a convention to focus on the latest stable Python version. It would be recommended to have a 100% on 3.13 when going live with the switcher. For the time being, we could build the Greek documentation yet without including it in the switcher? ( |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Yes, but it's probably best to merge this when the 3.13 docs are ready either way. We also don't have very much time to work on this, so we've been a bit slow with the port. |
Folks, this can be merged now, I think. We've had some slow progress lately, but the minimum requirements are now fulfilled for all of 3.12, 3.13 and 3.14. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hmm, we don't actually state in PEP 545 which version should meet the requirements. Something we should probably add in future amendments. cc @JulienPalard / @willingc |
Custom & practice is the current latest minor version, or 'what |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- bugs.html: "If you find a bug in the theme ..." is untranslated.
- functions.html: 'Built-in' appears untranslated, as do the version* directives, and a few reference titles (e.g. 'asynchronous iterator'). I believe (though unsure) that the last of these requires translating the titles of the relevant source articles, so can probably be overlooked. I think the first two should be addressed before being added to the switcher, though.
I've suggested setting in_prod
to false, similarly to the recently merged Romanian translation. This will build on the docsbuild infrastructure, and we can revisit the 545 targets hopefully very soon.
A
[languages.el] | ||
name = "Greek" | ||
translated_name = "Ελληνικά" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in_prod = false | |
el
, but the more common name isgr
, we'd named the repositorypython-docs-gr
. I've added the ability to have an alternative repository name. If people think that's a bad idea, we can always rename the repository as well.