-
-
Notifications
You must be signed in to change notification settings - Fork 867
Update translation/translators.rst
#1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- `AFPy/python-docs-fr <https://git.afpy.org/AFPy/python-docs-fr/>`_ | ||
:github:`Mirror <python/python-docs-fr>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @JulienPalard Is this correct, it is what I gathered from the repositories though it is in French so I may be wrong?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct. French translation happens at AFPy's Gitea and are simply mirrored to GitHub.
Instead of "GitHub" or "AFPy", there could be "repo" or "repository" text which links to the proper translation repository (for all rows in the table). Please add a comma before "Mirror"
- `AFPy/python-docs-fr <https://git.afpy.org/AFPy/python-docs-fr/>`_ | ||
:github:`Mirror <python/python-docs-fr>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is correct. French translation happens at AFPy's Gitea and are simply mirrored to GitHub.
Instead of "GitHub" or "AFPy", there could be "repo" or "repository" text which links to the proper translation repository (for all rows in the table). Please add a comma before "Mirror"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @StanFromIreland, I rereviewed. Thanks for putting together. I have only one small grammar nit and a question about max depth. Neither are blockers so I'm going to approve this PR. After I hear back from you or others, I am happy to merge.
Co-authored-by: Carol Willing <[email protected]>
Thank you for your work on it! I've left some comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my comments, answering to some of the replies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that we incorporate some of @hugovk's suggestions. Thanks @StanFromIreland.
@hugovk I'm leaving this in your capable hands to merge when your suggestions are incorporated. @StanFromIreland Thanks for working together with folks on the review. I'm loving how these docs are coming together. |
Co-authored-by: Hugo van Kemenade <[email protected]>
Suggestions were added and #1585 added to address the build scripts suggestion.
Thanks @StanFromIreland and to everyone who reviewed this PR. Working together we now have much clearer info for coordinators and translators. 🚀 Keep up the collaboration. ☀️ |
Many thanks to everyone who reviewed! |
Thanks @StanFromIreland and everyone that contributed for improving translation docs! |
This is a very rough draft that has been opened for the purpose of asking some questions and is subject to a lot of change, some of which I have already done locally.There are some small changes to
coordinating.rst
in this pull request which came up as I was working on this.cc @willingc
📚 Documentation preview 📚: https://cpython-devguide--1576.org.readthedocs.build/documentation/translations