Skip to content

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Jun 7, 2018

Refactor Proactor's data receiving code path. The idea is to always use
recv_into() and to emulate the old Protocol.data_received() path. This way
there is no read cancellation race or data loss in set_protocol() and
there's no performance degradation for both Protocol and BufferedProtocol.

This PR removes some outdated and now irrelevant proactor mock tests
(most of the removed mocked tests have an alternative working test
for BufferedProtocol).

https://bugs.python.org/issue33694

@1st1
Copy link
Member Author

1st1 commented Jun 7, 2018

@vstinner is working on another PR that doesn't have a problem of reusing a buffer from the old protocol after set_protocol() is called.

@1st1 1st1 closed this Jun 7, 2018
@1st1 1st1 deleted the fix_proactor branch June 7, 2018 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants