Skip to content

Kill the AppVeyor file whitelist #5121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2018
Merged

Kill the AppVeyor file whitelist #5121

merged 1 commit into from
Jan 7, 2018

Conversation

zware
Copy link
Member

@zware zware commented Jan 7, 2018

It's more trouble than it's worth, since it only checks the HEAD commit of a PR rather than the full diff against the base branch for changed files.

It's more trouble than it's worth, since it only checks the HEAD commit of a PR rather than the full diff against the base branch for changed files.
@miss-islington
Copy link
Contributor

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

@zware zware deleted the kill-appveyor-whitelist branch January 7, 2018 02:41
@miss-islington
Copy link
Contributor

Sorry, @zware, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7f7de371f947dc38e67505601927e9bc58fa268a 3.6

@miss-islington
Copy link
Contributor

Sorry, @zware, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7f7de371f947dc38e67505601927e9bc58fa268a 2.7

zware added a commit to zware/cpython that referenced this pull request Jan 7, 2018
It's more trouble than it's worth, since AppVeyor only checks the HEAD commit of a PR rather than the full diff against the base branch to decide which files changed..
(cherry picked from commit 7f7de37)
@bedevere-bot
Copy link

GH-5122 is a backport of this pull request to the 3.6 branch.

zware added a commit to zware/cpython that referenced this pull request Jan 7, 2018
It's more trouble than it's worth, since AppVeyor only checks the HEAD commit of a PR rather than the full diff against the base branch to decide which files changed..
(cherry picked from commit 7f7de37)
@bedevere-bot
Copy link

GH-5123 is a backport of this pull request to the 2.7 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants