Skip to content

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jan 1, 2018

'break' and 'return' are never used inside 'finally' clause in the stdlib.

https://bugs.python.org/issue32478

@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the break-return-inside-finally branch January 2, 2018 00:38
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2018
@bedevere-bot
Copy link

GH-5080 is a backport of this pull request to the 3.6 branch.

@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 2.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7cc42c356b0dc5ad9eaa9392789e84bd4aa1c7de 2.7

@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 2, 2018
@bedevere-bot
Copy link

GH-5083 is a backport of this pull request to the 3.6 branch.

@bedevere-bot
Copy link

GH-5084 is a backport of this pull request to the 2.7 branch.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Jan 2, 2018
serhiy-storchaka added a commit that referenced this pull request Jan 2, 2018
@serhiy-storchaka serhiy-storchaka restored the break-return-inside-finally branch January 2, 2018 09:30
@serhiy-storchaka serhiy-storchaka deleted the break-return-inside-finally branch July 7, 2018 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants