bpo-38735: Don't fail when importing from / with sys.pycache_prefix set #30456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open for 30 days with no activity. |
Member
|
You can test it without writing a file. >>> from importlib.util import cache_from_source
>>> import os
>>> os.chdir('/')
>>> cache_from_source('spam.py')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
cache_from_source('spam.py')
~~~~~~~~~~~~~~~~~^^^^^^^^^^^
File "<frozen importlib._bootstrap_external>", line 558, in cache_from_source
IndexError: string index out of range |
encukou
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
brettcannon
approved these changes
Feb 27, 2024
encukou
added
needs backport to 3.13
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @encukou for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 18, 2025
…et (pythonGH-30456) (cherry picked from commit d8a9466) Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 18, 2025
…et (pythonGH-30456) (cherry picked from commit d8a9466) Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-137905 is a backport of this pull request to the 3.13 branch. |
|
GH-137906 is a backport of this pull request to the 3.14 branch. |
Agent-Hellboy
pushed a commit
to Agent-Hellboy/cpython
that referenced
this pull request
Aug 19, 2025
…et (pythonGH-30456) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-137905 is a backport of this pull request to the 3.13 branch. |
|
GH-137906 is a backport of this pull request to the 3.14 branch. |
encukou
added a commit
that referenced
this pull request
Sep 18, 2025
…efix set (GH-30456) (GH-137905) (cherry picked from commit d8a9466) Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
encukou
added a commit
that referenced
this pull request
Oct 7, 2025
…efix set (GH-30456) (GH-137906) (cherry picked from commit d8a9466) Co-authored-by: Petr Viktorin <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue, but testing it would require putting a file in the root directory.
https://bugs.python.org/issue38735
gh-#82916