Skip to content

Added indents that prevented Pygubu from working #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Added indents that prevented Pygubu from working #292

wants to merge 1 commit into from

Conversation

theOtterWizard
Copy link

Pygubu didn't work for me without them. Other programs may rely on them too.

Pygubu didn't work for me without them. Other programs may rely on them too.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:

  1. If you don't have an account on b.p.o, please create one
  2. Make sure your GitHub username is listed in "Your Details" at b.p.o
  3. If you have not already done so, please sign the PSF contributor agreement. The "bugs.python.org username " requested by the form is the "Login name" field under "Your Details".
  4. If you just signed the CLA, please wait at least one US business day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  5. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@louisom
Copy link
Contributor

louisom commented Feb 25, 2017

@Silver-Void your patch makes CI break, and I think this is not a bug for cpython itself.

Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for i in range(10):
    ...
else:
    ...

is valid Python code and your patch actually broke test_locale:

======================================================================
ERROR: test_option_locale (test.test_calendar.CommandLineTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/python/cpython/Lib/test/test_calendar.py", line 765, in test_option_locale
    lang, enc = locale.getdefaultlocale()
TypeError: 'NoneType' object is not iterable

Please report your problem to Pygubu developers.

@theOtterWizard
Copy link
Author

Sorry, I thought it was wrong. I'm quite an amateur.

akruis pushed a commit to akruis/cpython that referenced this pull request Jul 31, 2021
extract_slp_info.py

A modification of "extract_slp_info.py" now triggers a recreation of
"slp_exttype.h".
akruis added a commit to akruis/cpython that referenced this pull request Jul 31, 2021
…act_slp_info.py

A modification of "extract_slp_info.py" now triggers a recreation of "slp_exttype.h".
jaraco pushed a commit that referenced this pull request Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants