-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
bpo-45506: Normalize _PyPathConfig.stdlib_dir when calculated. #29040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-45506: Normalize _PyPathConfig.stdlib_dir when calculated. #29040
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
./python -m test.regrtest test_embed -v
still fails in an out of tree build for me with this change. As does test_gdb. Both appear to be having trouble importing encodings
? Others such as test_importlib no longer fail.
When you're done making the requested changes, leave the comment: |
I ran the full test suite:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even with this PR, test_embed
and test_unittest
still fail.
Hmm, I don't get failures in test_unittest. At this point, I've fixed the problem with test_embed and only need to deal with failures in subprocess due to that first commit. |
With that latest commit I got all the tests to pass in an out-of-tree build. |
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this one is good. test_embed still fails for me using this branch but I think there was another PR you already merged that addressed that.
@ericsnowcurrently: Please replace |
The recently added
PyConfig.stdlib_dir
was being set with ".." entries. When__file__
was added for from modules this caused a problem on out-of-tree builds. This PR fixes that by normalizing "stdlib_dir" when it is calculated in getpath.c.https://bugs.python.org/issue45506