bpo-43425: Update setup.py not to use distutils.log #26969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
corona10
changed the title
corona10
changed the title
corona10
force-pushed
the
bpo-43425-setup
branch
2 times, most recently
from
1709cb3 to
b1ea241
Compare
mmdbalkhi
approved these changes
Jul 1, 2021
vstinner
reviewed
Jul 1, 2021
| @@ -2667,7 +2673,7 @@ def copy_scripts(self): | |||
| newfilename = filename + fullversion | |||
| else: | |||
| newfilename = filename + minoronly | |||
| log.info('renaming %s to %s', filename, newfilename) | |||
| log.info(f'renaming {filename} to {newfilename}') | |||
There was a problem hiding this comment.
With your change, I no longer see this message. IMO you should mimick distutils setup() function which sets the logging thredshold to INFO:
File "/home/vstinner/python/main/./setup.py", line 2698, in main
setup(# PyPI Metadata (PEP 301)
File "/home/vstinner/python/main/Lib/distutils/core.py", line 134, in setup
ok = dist.parse_command_line()
File "/home/vstinner/python/main/Lib/distutils/dist.py", line 477, in parse_command_line
log.set_verbosity(self.verbose)
File "/home/vstinner/python/main/Lib/distutils/log.py", line 78, in set_verbosity
set_threshold(INFO)
To see the message on the main branch:
$ rm -rf build/scripts-3.11/
$ make
(...)
renaming build/scripts-3.11/pydoc3 to build/scripts-3.11/pydoc3.11
renaming build/scripts-3.11/idle3 to build/scripts-3.11/idle3.11
renaming build/scripts-3.11/2to3 to build/scripts-3.11/2to3-3.11
vstinner
approved these changes
Jul 1, 2021
|
Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 2, 2021
(cherry picked from commit a7e251b) Co-authored-by: Dong-hee Na <[email protected]>
|
GH-26986 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Jul 2, 2021
(cherry picked from commit a7e251b) Co-authored-by: Dong-hee Na <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43425