Skip to content

bpo-43293: Doc: move note about GIL to top of threading module #24622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

quantum5
Copy link
Contributor

@quantum5 quantum5 commented Feb 22, 2021

The note about the GIL was buried pretty deep in the threading documentation,
and this made it hard for first time users to discover why their attempts
at using threading to parallelize their application did not work.

In this commit, the note is moved to the top of the module documention for
visibility.

https://bugs.python.org/issue43293

The note about the GIL was buried pretty deep in the threading documentation,
and this made it hard for first time users to discover why their attempts
at using threading to parallelizing their application did not work.

In this commit, the note is moved to the top of the module documention for
visibility.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@quantum5

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@miss-islington
Copy link
Contributor

Thanks @quantum5 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @quantum5 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Thanks @quantum5 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-24640 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 24, 2021
@miss-islington
Copy link
Contributor

Sorry, @quantum5 and @pablogsal, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 32181be6081f6c70a1e0bd0540050805c8e88e83 3.7

@miss-islington
Copy link
Contributor

Sorry @quantum5 and @pablogsal, I had trouble checking out the 3.8 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 32181be6081f6c70a1e0bd0540050805c8e88e83 3.8

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 24, 2021
…nGH-24622)

The note about the GIL was buried pretty deep in the threading documentation,
and this made it hard for first time users to discover why their attempts
at using threading to parallelizing their application did not work.

In this commit, the note is moved to the top of the module documention for
visibility.
(cherry picked from commit 32181be)

Co-authored-by: Guanzhong Chen <[email protected]>
@miss-islington
Copy link
Contributor

Thanks @quantum5 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @quantum5 for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-24641 is a backport of this pull request to the 3.8 branch.

@miss-islington
Copy link
Contributor

Sorry, @quantum5 and @pablogsal, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 32181be6081f6c70a1e0bd0540050805c8e88e83 3.7

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 24, 2021
…nGH-24622)

The note about the GIL was buried pretty deep in the threading documentation,
and this made it hard for first time users to discover why their attempts
at using threading to parallelizing their application did not work.

In this commit, the note is moved to the top of the module documention for
visibility.
(cherry picked from commit 32181be)

Co-authored-by: Guanzhong Chen <[email protected]>
@pablogsal
Copy link
Member

@quantum5 could you do the manual backport to 3.7?

miss-islington added a commit that referenced this pull request Feb 24, 2021
)

The note about the GIL was buried pretty deep in the threading documentation,
and this made it hard for first time users to discover why their attempts
at using threading to parallelizing their application did not work.

In this commit, the note is moved to the top of the module documention for
visibility.
(cherry picked from commit 32181be)

Co-authored-by: Guanzhong Chen <[email protected]>
miss-islington added a commit that referenced this pull request Feb 24, 2021
)

The note about the GIL was buried pretty deep in the threading documentation,
and this made it hard for first time users to discover why their attempts
at using threading to parallelizing their application did not work.

In this commit, the note is moved to the top of the module documention for
visibility.
(cherry picked from commit 32181be)

Co-authored-by: Guanzhong Chen <[email protected]>
quantum5 added a commit to quantum5/cpython that referenced this pull request Feb 24, 2021
…ythonGH-24622)

The note about the GIL was buried pretty deep in the threading documentation,
and this made it hard for first time users to discover why their attempts
at using threading to parallelizing their application did not work.

In this commit, the note is moved to the top of the module documention for
visibility..
(cherry picked from commit 32181be)

Co-authored-by: Guanzhong Chen <[email protected]>
@bedevere-bot
Copy link

GH-24642 is a backport of this pull request to the 3.7 branch.

@quantum5
Copy link
Contributor Author

@pablogsal I manually backported this to the 3.7 branch. Can you approve and merge the pull request?

@pablogsal
Copy link
Member

@pablogsal I manually backported this to the 3.7 branch. Can you approve and merge the pull request?

Done 👍 Thanks a lot

pablogsal pushed a commit that referenced this pull request Feb 26, 2021
…H-24622) (#24642)

The note about the GIL was buried pretty deep in the threading documentation,
and this made it hard for first time users to discover why their attempts
at using threading to parallelizing their application did not work.

In this commit, the note is moved to the top of the module documention for
visibility..
(cherry picked from commit 32181be)

Co-authored-by: Guanzhong Chen <[email protected]>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
…nGH-24622)

The note about the GIL was buried pretty deep in the threading documentation,
and this made it hard for first time users to discover why their attempts
at using threading to parallelizing their application did not work.

In this commit, the note is moved to the top of the module documention for
visibility.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants