Skip to content

bpo-41528 Use math module in turtle #21837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2020
Merged

bpo-41528 Use math module in turtle #21837

merged 2 commits into from
Sep 1, 2020

Conversation

TrangOul
Copy link
Contributor

@TrangOul TrangOul commented Aug 12, 2020

Use angle-related functions from math module instead of reinventing the wheel.

https://bugs.python.org/issue41528

Use angle-related functions from math module instead of reinventing the wheel.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@TrangOul

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@TrangOul TrangOul changed the title Use math module in turtle bpo-41528 Use math module in turtle Aug 12, 2020
@terryjreedy terryjreedy reopened this Aug 31, 2020
@terryjreedy
Copy link
Member

Travis timed out, restarted with close/open. Will merge when possible.

@terryjreedy terryjreedy reopened this Aug 31, 2020
@terryjreedy
Copy link
Member

terryjreedy commented Sep 1, 2020

@vstinner Travis failed again, 3rd time, but this time only Travis.
Not sure if same of 6 subtests. Might PR need to be redone?
I managed to log and restart particular test this time.

$ xvfb-run make -C Doc/ PYTHON=../python SPHINXOPTS="-q -W -j4" doctest
make: Entering directory '/home/travis/build/python/cpython/Doc'
make[1]: Entering directory '/home/travis/build/python/cpython/Doc'
mkdir -p build
Missing the required blurb or sphinx-build tools.
Please run 'make venv' to install local copies.
Makefile:49: recipe for target 'build' failed
make[1]: *** [build] Error 1
make[1]: Leaving directory '/home/travis/build/python/cpython/Doc'
Testing of doctests in the sources finished, look at the results in build/doctest/output.txt
Makefile:127: recipe for target 'doctest' failed
make: *** [doctest] Error 1
make: Leaving directory '/home/travis/build/python/cpython/Doc'

Docs/docs test also failed, no error log available. PR does not changes docs so doc tests should not be needed.

@vstinner
Copy link
Member

vstinner commented Sep 1, 2020

@vstinner Travis failed again, 3rd time, but this time only Travis.

You are a victim of https://bugs.python.org/issue41685 You can try to rebase your PR on top of master to retrieve a4c4e17 fix.

@terryjreedy terryjreedy merged commit 6844b56 into python:master Sep 1, 2020
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
Use angle-related functions from math module instead of reinventing the wheel.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants