Skip to content

bpo-39822: Use NULL instead of None for empty attrib in Element. #18735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 9, 2020
Merged

bpo-39822: Use NULL instead of None for empty attrib in Element. #18735

merged 4 commits into from
Mar 9, 2020

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Mar 2, 2020 •
edited by bedevere-bot
Loading

scoder
scoder approved these changes Mar 2, 2020
View reviewed changes
Copy link
Contributor

@scoder scoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement!

@serhiy-storchaka serhiy-storchaka mentioned this pull request Mar 8, 2020
Merged
@serhiy-storchaka serhiy-storchaka merged commit dccd41e into python:master Mar 9, 2020
@serhiy-storchaka serhiy-storchaka deleted the etree-null branch March 9, 2020 13:12
@serhiy-storchaka
Copy link
Member Author

Thank you for your review @scoder!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scoder scoder scoder approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@serhiy-storchaka @scoder @the-knights-who-say-ni @bedevere-bot