-
-
Notifications
You must be signed in to change notification settings - Fork 32.7k
Ignore .pytest_cache/. #16595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore .pytest_cache/. #16595
Conversation
Not sure how/if this should be backported. |
Sorry if I'm missing something but which plugin are you referring to? Was it added to the workflow recently? AFAIK we don't use or endorse pytest in cpython development. |
@ammaraskar The Python plugin for Visual Studio Code generates these caches when the project is opened. I figured that since caches for other “unofficial” tools like Not a huge deal, but could be helpful to others. |
Sounds good 👍 Maybe group up the vscode related ones and put a comment there just so people know why? |
Well, this is a pytest cache, not a VSCode cache. The plugin just happens to trigger it ( |
The Python plugin creates |
mypy cache is an older manual addition: #6614 Is is possible to run (some) CPython tests with pytest? If not, an IDE plugin dumping things to all your projects uncontrollably does not seem good. |
It is possible. In fact, I've used pytest in the past to get nice iterative output, with something like Again, this is just a suggestion. I can always add it to my personal ignore file, but I figured if it was useful for me, it might be useful for others! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking at our .gitignore
, it's obvious the current policy is to add everything that is common enough to be useful to many people. So if someone wants this, and there's surely no possible harm, I don't see why not :)
Since the vast majority of development is done based on the master branch, I don't think it is worth backporting this. |
Thanks @taleinat! |
Keeps my plugin from sneaking JSON files into commits.