Skip to content

[2.7] bpo-29243: Fix Makefile with respect to --enable-optimizations … #1522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2017

Conversation

torsava
Copy link
Contributor

@torsava torsava commented May 9, 2017

…(GH-1478)

  • bpo-29243: Fix Makefile with respect to --enable-optimizations

When using the Profile Guided Optimization (./configure --enable-optimizations)
Python is built not only during make but rebuilt again during make test,
make install and others. This patch fixes the issue.

Note that this fix produces no change at all in the Makefile if configure is
run witout --enable-optimizations.

  • !squash.
    (cherry picked from commit a1054c3)

…ythonGH-1478)

* bpo-29243: Fix Makefile with respect to --enable-optimizations

When using the Profile Guided Optimization (./configure --enable-optimizations)
Python is built not only during `make` but rebuilt again during `make test`,
`make install` and others. This patch fixes the issue.

Note that this fix produces no change at all in the Makefile if configure is
run witout --enable-optimizations.

* !squash.
(cherry picked from commit a1054c3)
@torsava
Copy link
Contributor Author

torsava commented May 9, 2017

Differences with the 3.x branch:

  • memtest: also got @DEF_MAKE_RULE@ instead of all
  • patchcheck: does not have all in the prerequisites, so it was net changed

@vstinner vstinner merged commit a473a73 into python:2.7 May 9, 2017
@vstinner
Copy link
Member

vstinner commented May 9, 2017

Thank you! It seems like the bug is now fixed in all maintained branches!

@torsava
Copy link
Contributor Author

torsava commented May 9, 2017

I believe so. Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants