[3.8] bpo-21478: Record calls to parent when autospecced objects are used as child with attach_mock (GH 14688) #14902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s child with attach_mock (GH 14688) * Clear name and parent of mock in autospecced objects used with attach_mock * Add NEWS entry * Fix reversed order of comparison * Test child and standalone function calls * Use a helper function extracting mock to avoid code duplication and refactor tests. (cherry picked from commit 7397cda) Co-authored-by: Xtreak <[email protected]>
Contributor
Author
|
@tirkarthi and @cjw296: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@tirkarthi and @cjw296: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
@tirkarthi and @cjw296: Status check is done, and it's a success ✅ . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear name and parent of mock in autospecced objects used with attach_mock
Add NEWS entry
Fix reversed order of comparison
Test child and standalone function calls
Use a helper function extracting mock to avoid code duplication and refactor tests.
(cherry picked from commit 7397cda)
Co-authored-by: Xtreak [email protected]
https://bugs.python.org/issue21478