[2.7] bpo-30265: support.unlink() don't catch any OSError #1456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test_sax fails with this change on Windows. I would prefer to first fix http://bugs.python.org/issue30264 |
vstinner
changed the title
Lib/test/support/__init__.py
Outdated
| except OSError: | ||
| pass | ||
| except OSError as exc: | ||
| if exc.errno in (errno.ENOENT, errno.ENOTDIR): |
There was a problem hiding this comment.
Maybe invert the condition?
if exc.errno not in (errno.ENOENT, errno.ENOTDIR):
raise
support.unlink() now only ignores ENOENT and ENOTDIR, instead of ignoring any OSError exception.
|
@serhiy-storchaka: This PR is now blocked by http://bugs.python.org/issue30264 (xml.sax bug). Would you mind to review my PR #1451 please? |
serhiy-storchaka
approved these changes
May 5, 2017
|
I fixed http://bugs.python.org/issue30264 so I was able to merged this change as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support.unlink() now only ignores ENOENT and ENOTDIR, instead of
ignoring any OSError exception.