bpo-30264: xml.sax.parse() closes the parser on error #1444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Haypo, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bitdancer, @serhiy-storchaka and @Yhg1s to be potential reviewers. |
The xml.sax.parse() function now closes the parser on error to not leak resources like open files.
| # Collect leaked file. | ||
| gc.collect() | ||
| with self.assertRaises(SAXException): | ||
| self.check_parse(TESTFN) | ||
| with open(TESTFN, 'rb') as f: | ||
| with self.assertRaises(SAXException): | ||
| self.check_parse(f) |
There was a problem hiding this comment.
Shouldn't check that the file is closed now?
|
I proposed a different approach: see PR #1451. |
|
Abandonned in favor of the PR #1451. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xml.sax.parse() function now closes the parser on error to not leak resources like open files.