Skip to content

bpo-30345: travis: use -Og cflags with --with-pydebug #14423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2019
Merged

bpo-30345: travis: use -Og cflags with --with-pydebug #14423

merged 1 commit into from
Jun 27, 2019

Conversation

methane
Copy link
Member

@methane methane commented Jun 27, 2019 •
edited by bedevere-bot
Loading

@vstinner vstinner mentioned this pull request Jun 27, 2019
Merged
vstinner
vstinner requested changes Jun 27, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 3 ./configure calls in .travis.yml. Either update them all, or set -Og in global CFLAGS.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@methane
Copy link
Member Author

methane commented Jun 27, 2019

There are 3 ./configure calls in .travis.yml. Either update them all, or set -Og in global CFLAGS.

-Og is useful only when running test_gdb.
In other places, -O3 is used automatically because there is no --with-pydebug. It is much faster than -Og.

vstinner
vstinner approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost, sorry. I misread .travis.yml. So your change LGTM.

@methane methane merged commit 21cfae1 into python:master Jun 27, 2019
@miss-islington
Copy link
Contributor

Thanks @methane for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@methane methane deleted the travis-og branch June 27, 2019 17:05
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2019
@methane @miss-islington
bpo-30345: travis: use -Og with --with-pydebug (pythonGH-14423)
ba4a6c3 
(cherry picked from commit 21cfae1)

Co-authored-by: Inada Naoki <[email protected]>
@bedevere-bot
Copy link

GH-14427 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 27, 2019
@miss-islington @methane
bpo-30345: travis: use -Og with --with-pydebug (GH-14423)
60f24b2 
(cherry picked from commit 21cfae1)

Co-authored-by: Inada Naoki <[email protected]>
lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@methane @lisroach
bpo-30345: travis: use -Og with --with-pydebug (pythonGH-14423)
81a2984
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@methane @DinoV
bpo-30345: travis: use -Og with --with-pydebug (pythonGH-14423)
5e041f1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@methane @bedevere-bot @miss-islington @vstinner @the-knights-who-say-ni