Skip to content

gh-135608: Add a null check for attribute promotion to fix a JIT crash #135613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

gh-135608: Add a null check for attribute promotion to fix a JIT crash #135613

wants to merge 7 commits into from
+48 −2

Conversation

Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Jun 17, 2025 •
edited by bedevere-app bot
Loading

@Fidget-Spinner Fidget-Spinner changed the title gh-135608: Add a null check for attribute promotion to fix a crash gh-135608: Add a null check for attribute promotion to fix a JIT crash Jun 17, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 17, 2025
Open
@Fidget-Spinner Fidget-Spinner requested a review from tomasr8 June 17, 2025 13:37
@Fidget-Spinner @devdanzin
Update test_opt.py
092ecc5 
Co-Authored-By: devdanzin <[email protected]>
@tomasr8
Copy link
Member

tomasr8 commented Jun 17, 2025

I'll take a look today or tomorrow :)

tomasr8
tomasr8 reviewed Jun 18, 2025
View reviewed changes
tomasr8
tomasr8 approved these changes Jun 19, 2025
View reviewed changes
Copy link
Member

@tomasr8 tomasr8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two nits/questions, otherwise LGTM! :)

@Fidget-Spinner
Copy link
Member Author

Thank you for the review. I have addressed the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomasr8 tomasr8 tomasr8 approved these changes

@brandtbucher brandtbucher Awaiting requested review from brandtbucher

@markshannon markshannon Awaiting requested review from markshannon

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fidget-Spinner @tomasr8