Skip to content

gh-91048: Chain some exceptions in _testexternalinspection.c #132970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 2, 2025
Merged

gh-91048: Chain some exceptions in _testexternalinspection.c #132970

merged 8 commits into from
May 2, 2025

Conversation

sergey-miryanov
Copy link
Contributor

@sergey-miryanov sergey-miryanov commented Apr 25, 2025 •
edited
Loading

  1. Added extra Py_UNREACHABLE calls on unsupported platforms
  2. Remove unused refcnt read
  3. Set result to 0 if fd closing failed
  4. Chain some exceptions to get more info if failed

@sergey-miryanov sergey-miryanov changed the title Chain some exceptions in _testexternalinspection.c gh-91048: Chain some exceptions in _testexternalinspection.c Apr 25, 2025
@bedevere-app bedevere-app bot mentioned this pull request Apr 25, 2025
Closed
picnixz
picnixz reviewed Apr 25, 2025
View reviewed changes
@sergey-miryanov sergey-miryanov marked this pull request as ready for review April 25, 2025 21:00
@sergey-miryanov
Copy link
Contributor Author

@pablogsal Please take a look.

pablogsal
pablogsal approved these changes May 2, 2025
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is a great improvement. Thanks a lot!

@pablogsal pablogsal merged commit bd2ed7c into python:main May 2, 2025
49 checks passed
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@sergey-miryanov @Pranjal095
pythongh-91048: Chain some exceptions in _testexternalinspection.c (p…
12e7c87 
…ython#132970)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sergey-miryanov @picnixz @pablogsal