Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speedup
test_pyrepl
by speeding uptest_unix_console.py
/test_windows_console.py
. Especially in case of Windows, almost all the time is spent there, and these tests are unnecessarily slow because they are not mockingwait
:cpython/Lib/_pyrepl/unix_console.py
Lines 419 to 427 in d134bd2
cpython/Lib/_pyrepl/windows_console.py
Lines 523 to 532 in d134bd2
The tables show the times in seconds.
Linux 64bit debug build (only tested in WSL):
./python -m test -u curses test_pyrepl
./python -m test -u curses test_pyrepl.test_unix_console
Windows 64bit debug build:
python.bat -m test test_pyrepl
python.bat -m test test_pyrepl.test_windows_console
I've marked as skipped news - and think this is also a skip issue?