-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-130167: Improve the error case for textwrap.dedent
#132666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Would it be possible to add a test for this? |
Thanks. I suppose bytes would still TypeError implicitly, right? |
Yes, but with an error message from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, can we have the benchmarks for this change on empty strings? I don't think we lose much but I'm just curious.
I won't have time in the near future to run benchmarks. A |
cc @hroncok @picnixz
re
uses #130167