-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
gh-132493: lazy evaluation of annotations in typing._proto_hook
#132534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JelleZijlstra
merged 13 commits into
python:main
from
felixscherz:fix/protocol-isinstance-lazy-annotations
Apr 16, 2025
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
34c6039
gh-132493: enable protocol isinstance checks against classes with def…
felixscherz 8ad1181
fix: typo in test name
felixscherz 079cf59
test: add case for class implementing protocol with deferred annotations
felixscherz 998e83c
docs: add a news entry
felixscherz 92e5ab9
docs: reference Protocol and isinstance correctly
felixscherz 3413f78
feat: no longer check whether annotations is a mapping since it is gu…
felixscherz a82ac39
Merge branch 'main' into fix/protocol-isinstance-lazy-annotations
JelleZijlstra 8c7a1e9
feat: check for Generic subclass and Protocol first to improve perfor…
felixscherz 63e5a5b
test: add a test with a sub-protocol
felixscherz a820f7f
test: clarify override of method
felixscherz 19d925a
test: fix test by removing non-member attribute
felixscherz 316741e
feat: compute annotations only if necessary
felixscherz 3d13c56
fix: replace assertTrue(...) with helper methods
felixscherz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
Misc/NEWS.d/next/Library/2025-04-15-08-39-14.gh-issue-132493.V0gLkU.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
:class:`typing.Protocol` now uses :func:`annotationlib.get_annotations` when | ||
checking whether or not an instance implements the protocol with | ||
:func:`isinstance`. This enables support for ``isinstance`` checks against | ||
classes with deferred annotations. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.