gh-131152: Remove unused imports from tests (part 2) #131154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
requested review from
jaraco,
barneygale,
ethanfurman,
rhettinger,
warsaw,
FFY00,
ericsnowcurrently,
brettcannon,
ncoghlan,
pablogsal,
lysnikolaou and
ambv
as code owners
pablogsal
approved these changes
Mar 12, 2025
rhettinger
approved these changes
Mar 12, 2025
|
Merged, thanks for reviews. |
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
jaraco
reviewed
May 12, 2025
| @@ -5,7 +5,6 @@ | |||
| import pickle | |||
| import stat | |||
| import sys | |||
| import time | |||
There was a problem hiding this comment.
This change will get overwritten unless it's ported to zipp. I'm slightly surprised that there are unused imports, given that I run ruff over the codebase. Oh, I see now. gh-123424 has not yet been backported to zipp, and that's where time was used. So shouldn't be a problem getting this synced once that one is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.