gh-130730: Fix multiprocessing test_active_children() #130837
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace a sleep with an event: sleep is not a reliable synchronization primitive.
vstinner
added
skip news
needs backport to 3.12
colesbury
approved these changes
Mar 4, 2025
|
On Windows, I can easily reproduce the issue with: With this change, I cannot reproduce the issue anymore. I ran the test for 3 minutes (565 iterations). |
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 4, 2025
…-130837) Replace a sleep with an event: sleep is not a reliable synchronization primitive. (cherry picked from commit 3dd3675) Co-authored-by: Victor Stinner <[email protected]>
|
GH-130845 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Mar 4, 2025
…-130837) Replace a sleep with an event: sleep is not a reliable synchronization primitive. (cherry picked from commit 3dd3675) Co-authored-by: Victor Stinner <[email protected]>
|
GH-130846 is a backport of this pull request to the 3.12 branch. |
vstinner
added a commit
that referenced
this pull request
Mar 4, 2025
…) (#130846) gh-130730: Fix multiprocessing test_active_children() (GH-130837) Replace a sleep with an event: sleep is not a reliable synchronization primitive. (cherry picked from commit 3dd3675) Co-authored-by: Victor Stinner <[email protected]>
vstinner
added a commit
that referenced
this pull request
Mar 4, 2025
…) (#130845) gh-130730: Fix multiprocessing test_active_children() (GH-130837) Replace a sleep with an event: sleep is not a reliable synchronization primitive. (cherry picked from commit 3dd3675) Co-authored-by: Victor Stinner <[email protected]>
seehwan
pushed a commit
to seehwan/cpython
that referenced
this pull request
Apr 16, 2025
…30837) Replace a sleep with an event: sleep is not a reliable synchronization primitive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace a sleep with an event: sleep is not a reliable synchronization primitive.
test_active_childrenmultiprocessing test is flaky #130730