Skip to content

gh-129005: Update _pyio.BytesIO to use bytearray.resize on write #129702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 6, 2025
Merged

gh-129005: Update _pyio.BytesIO to use bytearray.resize on write #129702

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
63795c8
gh-129005: Update _pyio.BytesIO to use bytearray.resize on write
cmaloney Feb 5, 2025
7d30781
Update Lib/_pyio.py
cmaloney Feb 5, 2025
e192903
Update comment
cmaloney Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions Lib/_pyio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,10 +937,8 @@ def write(self, b):
return 0
pos = self._pos
if pos > len(self._buffer):
# Inserts null bytes between the current end of the file
# and the new write position.
padding = b'\x00' * (pos - len(self._buffer))
self._buffer += padding
# Pad buffer to pos with null bytes.
self._buffer.resize(pos)
self._buffer[pos:pos + n] = b
self._pos += n
return n
Expand Down
Loading