Skip to content

gh-102471: Change PyLongWriter_Discard(NULL) to do nothing #129339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025
Merged

gh-102471: Change PyLongWriter_Discard(NULL) to do nothing #129339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Doc/c-api/long.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -824,6 +824,6 @@ The :c:type:`PyLongWriter` API can be used to import an integer.

Discard a :c:type:`PyLongWriter` created by :c:func:`PyLongWriter_Create`.

*writer* must not be ``NULL``.
If *writer* is ``NULL``, no operation is performed.

The writer instance and the *digits* array are invalid after the call.
4 changes: 4 additions & 0 deletions Objects/longobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6953,6 +6953,10 @@ PyLongWriter_Create(int negative, Py_ssize_t ndigits, void **digits)
void
PyLongWriter_Discard(PyLongWriter *writer)
{
if (writer == NULL) {
return;
}

PyLongObject *obj = (PyLongObject *)writer;
assert(Py_REFCNT(obj) == 1);
Py_DECREF(obj);
Expand Down
Loading