getpath: Add comments highlighing details of the pyvenv.cfg detection #127966
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filipe Laíns <[email protected]
srinivasreddy
pushed a commit
to srinivasreddy/cpython
that referenced
this pull request
Jan 8, 2025
pelson
reviewed
Jan 17, 2025
| # Search for the 'home' key in pyvenv.cfg. Currently, we don't consider the | ||
| # presence of a pyvenv.cfg file without a 'home' key to signify the | ||
| # existence of a virtual environment — we quietly ignore them. | ||
| # XXX: If we don't find a 'home' key, we don't look for another pyvenv.cfg! |
There was a problem hiding this comment.
This comment is a bit confusing - there is only one searched path for pyvenv.cfg. Are you suggesting that there should be multiple places being looked at for pyvenv.cfg?
There was a problem hiding this comment.
Sorry for the delay getting back to you.
No, there are two paths, {executable_dir} and {executable_dir}/... Using the venv install scheme, pyvenv.cfg will be at {executable_dir}/.., but implementation also allows it to be alongside the executable.
See https://docs.python.org/3.14/c-api/init_config.html#init-path-config
If home is not set and a pyvenv.cfg file is present in the same directory as executable, or its parent, (...)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.