Skip to content

gh-71784: [doc] add usage examples for traceback.TracebackException #125189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Oct 10, 2024

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Oct 9, 2024

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@iritkatriel
Copy link
Member Author

Thank you @AlexWaygood !

@iritkatriel iritkatriel enabled auto-merge (squash) October 9, 2024 19:22
@iritkatriel
Copy link
Member Author

The docktest is failing. How do I run it on a Mac?

@AlexWaygood
Copy link
Member

make doctest from the Doc/ directory should do it. I'd also be okay with removing the .. doctest directive if it's too tricky; I now remember that it can be annoying getting doctests involving traceback output to work properly

@iritkatriel
Copy link
Member Author

make doctest from the Doc/ directory should do it. I'd also be okay with removing the .. doctest directive if it's too tricky; I now remember that it can be annoying getting doctests involving traceback output to work properly

Yes, and also they changed over the last few releases with locations/hilighting so it won't backport. I'll remove it.

@iritkatriel iritkatriel disabled auto-merge October 10, 2024 08:29
@AlexWaygood AlexWaygood merged commit f9ae5d1 into python:main Oct 10, 2024
23 checks passed
@miss-islington-app
Copy link

Thanks @iritkatriel for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2024
…tion (pythonGH-125189)

(cherry picked from commit f9ae5d1)

Co-authored-by: Irit Katriel <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 10, 2024
…tion (pythonGH-125189)

(cherry picked from commit f9ae5d1)

Co-authored-by: Irit Katriel <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Oct 10, 2024

GH-125247 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Oct 10, 2024
@bedevere-app
Copy link

bedevere-app bot commented Oct 10, 2024

GH-125248 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Oct 10, 2024
AlexWaygood added a commit that referenced this pull request Oct 10, 2024
AlexWaygood added a commit that referenced this pull request Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants