gh-123123: Fix display of syntax errors covering multiple lines #123131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skirpichev
reviewed
Aug 19, 2024
|
It seems, test_syntax_error_various_offsets() should be adjusted. |
Signed-off-by: Pablo Galindo <[email protected]>
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 19, 2024
…pythonGH-123131) (cherry picked from commit 48856ea) Co-authored-by: Pablo Galindo Salgado <[email protected]> Signed-off-by: Pablo Galindo <[email protected]>
|
GH-123147 is a backport of this pull request to the 3.13 branch. |
pablogsal
added a commit
that referenced
this pull request
Aug 19, 2024
GH-123131) (#123147) gh-123123: Fix display of syntax errors covering multiple lines (GH-123131) (cherry picked from commit 48856ea) Signed-off-by: Pablo Galindo <[email protected]> Co-authored-by: Pablo Galindo Salgado <[email protected]>
jeremyhylton
pushed a commit
to jeremyhylton/cpython
that referenced
this pull request
Aug 19, 2024
…python#123131) Signed-off-by: Pablo Galindo <[email protected]>
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…python#123131) Signed-off-by: Pablo Galindo <[email protected]>
tuuputamadre
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #123123