gh-118932: ChainMap.__contains__ performance improvement #118946
Merged
+5
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Maybe we could even improve the performance of |
rhettinger
approved these changes
May 11, 2024
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
bdraco
added a commit
to home-assistant/core
that referenced
this pull request
Aug 3, 2024
On slower systems, there is a noticable stall right after startup when all the discoveries hit if there are a lot of discoveries. While we have imporved this by avoding imports in the event loop, this is still apparent on slower systems. The any expressions kept coming up in the profile, but I had skipped over them, as I was thinking they could not be optimized. After reading python/cpython#118932, I realized its the any expressions themselves that perform poorly. This change unpacks the hot any expressions with the same solution as python/cpython#118946
Merged
19 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal change.
ChainMap.__contains__performance significantlyChainMap.getalso benefits from it