[3.12] gh-118164: str(10**10000) hangs if the C _decimal module is missing (GH-118503) #118584
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing (pythonGH-118503) * Initial stab. * Test the tentative fix. Hangs "forever" without this change. * Move the new test to a better spot. * New comment to explain why _convert_to_str allows any poewr of 10. * Fixed a comment, and fleshed out an existing test that appeared unfinished. * Added temporary asserts. Or maybe permanent ;-) * Update Lib/_pydecimal.py Co-authored-by: Serhiy Storchaka <[email protected]> * Remove the new _convert_to_str(). Serhiy and I independently concluded that exact powers of 10 aren't possible in these contexts, so just checking the string length is sufficient. * At least for now, add the asserts to the other block too. * 📜🤖 Added by blurb_it. --------- (cherry picked from commit 999f0c5) Co-authored-by: Tim Peters <[email protected]> Co-authored-by: Serhiy Storchaka <[email protected]> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
This was referenced May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial stab.
Test the tentative fix. Hangs "forever" without this change.
Move the new test to a better spot.
New comment to explain why _convert_to_str allows any poewr of 10.
Fixed a comment, and fleshed out an existing test that appeared unfinished.
Added temporary asserts. Or maybe permanent ;-)
Update Lib/_pydecimal.py
Co-authored-by: Serhiy Storchaka [email protected]
Serhiy and I independently concluded that exact powers of 10
aren't possible in these contexts, so just checking the
string length is sufficient.
At least for now, add the asserts to the other block too.
📜🤖 Added by blurb_it.
(cherry picked from commit 999f0c5)
Co-authored-by: Tim Peters [email protected]
Co-authored-by: Serhiy Storchaka [email protected]
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
_decimalmodule is missing #118164