Skip to content

gh-118272: set stacktop to 0 before freeing contents, to avoid access to invalid objects during GC #118478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 1, 2024
Merged

gh-118272: set stacktop to 0 before freeing contents, to avoid access to invalid objects during GC #118478

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aee54d3
gh-118272: set stacktop to 0 before freeing contents, to avoid access…
iritkatriel May 1, 2024
72938a4
Merge branch 'main' into stacktop
iritkatriel May 1, 2024
d70c835
Update Python/frame.c
iritkatriel May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Python/frame.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,10 +98,11 @@ void
_PyFrame_ClearLocals(_PyInterpreterFrame *frame)
{
assert(frame->stacktop >= 0);
for (int i = 0; i < frame->stacktop; i++) {
int stacktop = 0;
frame->stacktop = 0;
for (int i = 0; i < stacktop; i++) {
Py_XDECREF(frame->localsplus[i]);
}
frame->stacktop = 0;
Py_CLEAR(frame->f_locals);
}

Expand Down