Skip to content

gh-116742 : Fix assertIn check with [None, b'BDFL'] as values for stdout #116917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

gh-116742 : Fix assertIn check with [None, b'BDFL'] as values for stdout #116917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a01b79c
Fix : test_subprocess - test_check_output_timeout flaky
Jitendra-GRL Mar 16, 2024
4aa5893
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Lib/test/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ def test_check_output_timeout(self):
# this much time to start and print.
timeout=3)
self.fail("Expected TimeoutExpired.")
self.assertEqual(c.exception.output, b'BDFL')
self.assertIn(c.exception.output, [None, b'BDFL'])

def test_call_kwargs(self):
# call() function with keyword args
Expand Down Expand Up @@ -1691,7 +1691,7 @@ def test_check_output_timeout(self):
# Some heavily loaded buildbots (sparc Debian 3.x) require
# this much time to start and print.
timeout=3, stdout=subprocess.PIPE)
self.assertEqual(c.exception.output, b'BDFL')
self.assertIn(c.exception.output, [None, b'BDFL'])
# output is aliased to stdout
self.assertEqual(c.exception.stdout, b'BDFL')

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Tests/2024-03-16-21-33-50.gh-issue-116742.iZsD_C.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
skip