Skip to content

gh-116417: Argument Clinic: test generated Limited C API code for float args #116573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2024
Merged

gh-116417: Argument Clinic: test generated Limited C API code for float args #116573

merged 1 commit into from
Mar 11, 2024

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Mar 10, 2024 •
edited by bedevere-app bot
Loading

@erlend-aasland erlend-aasland requested a review from vstinner March 10, 2024 21:40
@bedevere-app bedevere-app bot mentioned this pull request Mar 10, 2024
Closed
@bedevere-app bedevere-app bot added the tests Tests in the Lib/test dir label Mar 10, 2024
@erlend-aasland
Copy link
Contributor Author

Follow-up of #116568

vstinner
vstinner approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erlend-aasland erlend-aasland merged commit 8d7fde6 into python:main Mar 11, 2024
@erlend-aasland erlend-aasland deleted the clinic/test-limited-capi-float branch March 11, 2024 07:44
@erlend-aasland
Copy link
Contributor Author

Thanks for the review :)

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@erlend-aasland @adorilson
pythongh-116417: Argument Clinic: test generated Limited C API code f…
493b403 
…or float args (python#116573)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@erlend-aasland @diegorusso
pythongh-116417: Argument Clinic: test generated Limited C API code f…
1c4c950 
…or float args (python#116573)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@erlend-aasland @vstinner